Attention is currently required from: Jakub Czapiga, Julius Werner.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83157?usp=email )
Change subject: Documentation: Use pkgconf over pkg-config
......................................................................
Patch Set 7:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83157/comment/5db17cb6_2d870454?usp... :
PS5, Line 7: tree: Use pkgconf over pkg-config
indeed to /usr/local/bin/pkg-config […]
Done
File tests/data/lib/lzma-test/data.2.bin:
https://review.coreboot.org/c/coreboot/+/83157/comment/6768ec43_91045c71?usp... :
PS1, Line 52: * pkgconf
You can probably drop `ibs=1`, but `skip=8` is mandatory to drop header from binary data. […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83157?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3e9a92d019854214a5760f705b9cbe3cabe6d2e8
Gerrit-Change-Number: 83157
Gerrit-PatchSet: 7
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Tue, 09 Jul 2024 07:30:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
czapiga@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr