[M] Change in coreboot[main]: drivers/pc80/pc/spkmodem.c: Use beep() instead of own implementation

[Nicholas Chin (Code Review)]

Attention is currently required from: Jérémy Compostella.

Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83372?usp=email )

Change subject: drivers/pc80/pc/spkmodem.c: Use beep() instead of own implementation
......................................................................

Patch Set 2:

(1 comment)

File src/drivers/pc80/pc/spkmodem.c:

https://review.coreboot.org/c/coreboot/+/83372/comment/47145c00_803f962e?usp... :
PS2, Line 93: make_tone(SPEAKER_PIT_FREQUENCY / 200, 0);
This call wasn't replaced because `beep()` silences the speaker at the end of the function and thus would make no tone with the `duration_msec` argument set to 0, whereas `make_tone()` left the speaker on. Thus, this would make a 200 Hz tone whenever coreboot wasn't actively transmitting a byte. Need to check if `spkmodem_recv` can handle not having this 200 Hz tone during inactive periods.