Attention is currently required from: Jason Glenesk, Nico Huber, Raul Rangel, Marshall Dawson, Felix Held.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60024 )
Change subject: mb/google/guybrush: Add PSP_S0I3_RESUME_VERSTAGE Kconfig option
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Ah, so there's hardware init because verstage runs before the bootblock, […]
bootblock is not running during s0i3 resume, just verstage.
On AMD, S0i3 is only entered after explicit request from Kernel. The kernel needs to send a shutdown command to the TPM before reset is asserted so the TPM state can be preserved and restored.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60024
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c185f787c1e77bd09f6cbbb1f47deb665ed0c79
Gerrit-Change-Number: 60024
Gerrit-PatchSet: 2
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 13 Dec 2021 13:59:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Gerrit-MessageType: comment