Attention is currently required from: Angel Pons, Jérémy Compostella, Nico Huber, Tarun Tuli.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/67493?usp=email )
Change subject: gma: Update transcoder setup for TGL
......................................................................
Patch Set 22:
(1 comment)
File common/hw-gfx-gma-transcoder.adb:
https://review.coreboot.org/c/libgfxinit/+/67493/comment/d482f496_d55b9d5e :
PS10, Line 288: (if Config.Has_Type_C_Ports
... I think my concern here was that we are using a Config constant just because […]
Sorry that's my bad, I was lazy that day apparently :P there indeed should be a separate Config option for this
--
To view, visit
https://review.coreboot.org/c/libgfxinit/+/67493?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: I4d7e2a24c54fcd9994f44bb0b10924dce48068e5
Gerrit-Change-Number: 67493
Gerrit-PatchSet: 22
Gerrit-Owner: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-CC: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 07 Jun 2023 15:58:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment