Attention is currently required from: Felix Singer, Tarun Tuli, Dinesh Gehlot, Kapil Porwal, Maximilian Brune, Angel Pons, Arthur Heymans, Lean Sheng Tan, Werner Zeh.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73128 )
Change subject: soc/intel/cmn: Include ME specification configuration at common
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/73128/comment/cb44fade_434b2989
PS1, Line 261: config ME_SPEC_11
Yeah but only if they give you some kind of useful information. In this case they don't.
we need some integer mapping to specify the ME spec number, hence, below mapping is making lots of sense
```
config ME_SPEC
int
default ME_SPEC_11 if SOC_INTEL_COMMON_BLOCK_ME_SPEC_11
```
now what u r suggesting is to write like this
```
config ME_SPEC
int
default 11 if SOC_INTEL_COMMON_BLOCK_ME_SPEC_11
```
inside the code just add preprocessing like below
#if CONFIG_ME_SPEC == 11
it might avoid adding few line. lets drop those configs then and use hardcoded value.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73128
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I817d14e52b0d353bbb4316d6362fcb80cbec3cda
Gerrit-Change-Number: 73128
Gerrit-PatchSet: 1
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Tue, 21 Feb 2023 19:01:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Dinesh Gehlot
digehlot@google.com
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-MessageType: comment