Attention is currently required from: Jakub Czapiga, Jan Dabros, Martin L Roth.
Nico Huber has posted comments on this change by Jakub Czapiga. ( https://review.coreboot.org/c/coreboot/+/70701?usp=email )
Change subject: util/sconfig: Allow to specify multiple chip base paths
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8:
Not sure if I fully understood the problem. In case this is still an issue:
We used to have macro checks in header files to exclude certain things for
specific languages (C / assembler / ASL). Maybe worth looking into.
Also, if FSP etc. headers are leaking into general coreboot code, that
should probably be avoided locally.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70701?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2be9d6bebd271f32effd1b14e6edcf47664f30a5
Gerrit-Change-Number: 70701
Gerrit-PatchSet: 8
Gerrit-Owner: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Jan Dabros
jsd@semihalf.com
Gerrit-Comment-Date: Fri, 05 Jul 2024 18:31:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No