[S] Change in coreboot[master]: soc/mediatek/mt8195/apusys_devapc.c: Fix unsigned comparison - coreboot-gerrit

19 Apr 2023


      Attention is currently required from: Hung-Te Lin, Arthur Heymans, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74553 )
Change subject: soc/mediatek/mt8195/apusys_devapc.c: Fix unsigned comparison
......................................................................
Patch Set 2:
(1 comment)
File src/soc/mediatek/mt8195/apusys_devapc.c:
https://review.coreboot.org/c/coreboot/+/74553/comment/a6758217_c4b11126 
PS2, Line 154: perm !=  0
This is wrong. `1` is a valid value. Since the underlying type of the enum is chosen by the compiler and isn't guaranteed to be an unsigned type, I think we still need the check.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74553
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12fccff2fb7d43fd4582afd518a7eab632908a5f
Gerrit-Change-Number: 74553
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Yidi Lin yidilin@google.com
Gerrit-Comment-Date: Wed, 19 Apr 2023 09:05:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment