Attention is currently required from: Kane Chen, Sridhar Siricilla, Tarun Tuli.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76880?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/intel/mtl: Change default for debug consent from 3 to 6
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76880/comment/ca60e83a_be7e6696 :
PS3, Line 9: USB DBC is very helpful for SoC debug.
: TraceHub needs to be enabled in coreboot ifdebug consent == 2 or 4.
: Debug consent == 6 enables USB DBC without TraceHub enabled.
: This patch changes debug consent to 6 in default to provide basic SoC
: debug capability.
Please do not wrap a line, just because a sentence ends, or add a blank line between paragraphs.
https://review.coreboot.org/c/coreboot/+/76880/comment/ba6e287c_db326896 :
PS3, Line 14:
Please also mention, you update the config description/help text.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76880?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic12528bdd8b1feda7f1b65045c863341f932d3a2
Gerrit-Change-Number: 76880
Gerrit-PatchSet: 3
Gerrit-Owner: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Wed, 02 Aug 2023 14:44:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment