Attention is currently required from: Arthur Heymans, Ashish Kumar Mishra, Martin Roth, Saurabh Mishra.
Subrata Banik has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/84142?usp=email )
Change subject: src/include/: Introducing a new BIT_32(x) macro.
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File src/include/types.h:
https://review.coreboot.org/c/coreboot/+/84142/comment/ee81a38e_e163d66a?usp... :
PS5, Line 27:
In file included from src/vendorcode/amd/opensil/genoa_poc/acpi.c:5:
src/vendorcode/amd/opensil/genoa_poc/opensil/xUSL/Include/SilCommon.h:26:9: error: 'BIT_32' macro redefined [-Werror,-Wmacro-redefined]
26 | #define BIT_32(X) (uint32_t)(1ul << (X))
| ^
src/include/types.h:25:9: note: previous definition is here
25 | #define BIT_32(x) (1u << (x))
| ^
1 error generated.
Adding @arthur@aheymans.xyz and @martin.roth@amd.corp-partner.google.com to see if a CPP guard can be applied for OpenSIL code (xUSL/Include/SilCommon.h:26:9)
```
#define BIT_64(X) (uint64_t)(1ull << (X))
#define BIT_32(X) (uint32_t)(1ul << (X))
#define BIT_16(X) (uint16_t)(1 << (X))
#define BIT_8(X) (uint8_t)(1 << (X))
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84142?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I70be1ccba59d25af2ba85a2014232072abf2f87d
Gerrit-Change-Number: 84142
Gerrit-PatchSet: 5
Gerrit-Owner: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.com
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-CC: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-CC: Sanju Jose Thottan
sanjujose.thottan@intel.com
Gerrit-CC: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Mon, 02 Sep 2024 05:26:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes