Attention is currently required from: Jérémy Compostella, Pranava Y N.
Paul Menzel has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84409?usp=email )
Change subject: mb/google/fatcat: Add HDA verb tables ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84409/comment/94639bc8_c6359e46?usp... : PS1, Line 8: Where did you get these from, or from what source did you create the file?
https://review.coreboot.org/c/coreboot/+/84409/comment/fb97c18d_85f7320d?usp... : PS1, Line 10: TEST=Boot on google fatcat board Tested how?
File src/mainboard/google/fatcat/variants/fatcat/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/84409/comment/7b2e5626_5f29817b?usp... : PS1, Line 79: /* Widget node 0x20 - 6 : * Silence data mode Threshold (-90dB) */ The recommended concise style is:
/* … … */