Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34724 )
Change subject: soc/intel/common: Implement power-failure-state handling
......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34724/5/src/soc/intel/common/block/...
File src/soc/intel/common/block/include/intelblocks/pmclib.h:
https://review.coreboot.org/c/coreboot/+/34724/5/src/soc/intel/common/block/...
PS5, Line 222: ,
no param name?
https://review.coreboot.org/c/coreboot/+/34724/5/src/soc/intel/common/block/...
PS5, Line 223: )
same here?
https://review.coreboot.org/c/coreboot/+/34724/5/src/soc/intel/common/block/...
PS5, Line 223: pmc_set_power_failure_state
Can you please add description to each of the functions as to how they differ? I believe one is a callback that SoC is supposed to provide? Also, it would be good to provide information about what params are expected.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34724
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6970a79d9b95373c2855f4c92232d2aa05963bb
Gerrit-Change-Number: 34724
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 07 Aug 2019 22:26:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment