Attention is currently required from: Andrey Petrov, Krishna P Bhat D, Ronak Kanabar, Sowmya Aralguppe, Subrata Banik, V Sowmya.
Varun Upadhyay has posted comments on this change by Varun Upadhyay. ( https://review.coreboot.org/c/coreboot/+/83055?usp=email )
Change subject: driver/intel/fsp2_0: Prevent error logs during S3 wakeup
......................................................................
Patch Set 4:
(1 comment)
File src/drivers/intel/fsp2_0/fsp_gop_blt.c:
https://review.coreboot.org/c/coreboot/+/83055/comment/354f6c00_18d20c01?usp... :
PS2, Line 245: /* CBMEM is locked for S3 resume path. */
: if (acpi_is_wakeup_s3())
: return;
I can investigate further, but the bmp_load_logo() function in lib/bmp_logo. […]
Can we resolve this for the error msg in S3 cycle ? And plan to include FW splash screen while resuming S3 if needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83055?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I13463b5409e248cf4843c9a887a47d73459972a3
Gerrit-Change-Number: 83055
Gerrit-PatchSet: 4
Gerrit-Owner: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Thu, 04 Jul 2024 09:24:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Varun Upadhyay
varun.upadhyay@intel.com