Attention is currently required from: Lance Zhao, Angel Pons.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55313 )
Change subject: arch/x86: Add register_new_ioapic() ......................................................................
Patch Set 9:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55313/comment/44ad53ac_eb92fcd2 PS1, Line 13: overlap when APIC Serial Bus is no longer used.
Hardware perspective is I/O APIC ID register has no functionality with System Bus delivery mode. […]
Ack
File src/arch/x86/ioapic.c:
https://review.coreboot.org/c/coreboot/+/55313/comment/01856f23_68ef5f35 PS3, Line 169: void register_new_ioapic(void *ioapic_base) : { : set_ioapic_id(ioapic_base, ioapic_id); : clear_vectors(ioapic_base, 0, ioapic_get_max_vectors(ioapic_base) - 1); : ioapic_id++; : }
Thanks. A simply search in gerrit didn't locate this change. […]
https://review.coreboot.org/c/coreboot/+/55571/8 too
With xeon_sp in mind, we potentially will want proper device nodes for IOAPICs and that would clear the dependency of calling order with ACPI generation.