Attention is currently required from: Derek Huang, Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj, Subrata Banik.
Shon Wang has posted comments on this change by Shon Wang. ( https://review.coreboot.org/c/coreboot/+/83593?usp=email )
Change subject: mb/google/brask/var/bujia: Add PsysPmax setting
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/brya/variants/bujia/ramstage.c:
https://review.coreboot.org/c/coreboot/+/83593/comment/72e29d1d_ff70448c?usp... :
PS6, Line 65: struct ec_params_adc_read req = {
: .adc_channel = 4,
: };
: struct ec_response_adc_read info;
: struct chromeec_command cmd = {
: .cmd_code = EC_CMD_ADC_READ,
: .cmd_size_in = sizeof(req),
: .cmd_data_in = &req,
: .cmd_size_out = sizeof(info),
: .cmd_data_out = &info,
: };
: google_chromeec_command(&cmd);
Can we add a helper function for this? e.g. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83593?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic6e9c6ce9f3179c7d63c1169695fbc23188456dd
Gerrit-Change-Number: 83593
Gerrit-PatchSet: 7
Gerrit-Owner: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 30 Aug 2024 09:59:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Derek Huang
derekhuang@google.com