Attention is currently required from: Martin Roth, Henry Sun, Paul Menzel, Tao Xia, Weimin Wu, Karthik Ramasubramanian.
zanxi chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51017 )
Change subject: mb/google/dedede/var/storo: Support LTE module
......................................................................
Patch Set 5:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51017/comment/83497173_5dcb1d5b
PS2, Line 14: TEST=LTE function is OK
Flash firmware and insert the SIM card to connect to the network.
Done
https://review.coreboot.org/c/coreboot/+/51017/comment/b99c1c57_34a5f722
PS2, Line 14: TEST=LTE function is OK
Flash firmware and insert the SIM card to connect to the network.
Done
File src/mainboard/google/dedede/variants/storo/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/51017/comment/a964ee14_f645c620
PS2, Line 5: smm-y += variant.c
Powering off LTE module will follow the system shutdown.
Done
File src/mainboard/google/dedede/variants/storo/variant.c:
https://review.coreboot.org/c/coreboot/+/51017/comment/872a59df_dbc5280c
PS2, Line 11: mdelay(20);
It's refer to spec about LTE850.
Done
https://review.coreboot.org/c/coreboot/+/51017/comment/e9b66539_8cacc530
PS2, Line 11: mdelay(20);
It's refer to spec about LTE850.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51017
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9aff9608e08eae00ab5ac8547f63bc83b62fea78
Gerrit-Change-Number: 51017
Gerrit-PatchSet: 5
Gerrit-Owner: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 02 Mar 2021 03:56:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-MessageType: comment