EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58045 )
Change subject: mb/google/brask: Correct SSD power sequence
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58045/comment/e68e0966_a160f6d0
PS3, Line 7: brask
Hmm, but it’s under variants (altough there is a baseboard directory). Very confusing.
b/c almost the code can share, like MI. we put guybrash and mancomb together as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58045
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I508f7e21888cc1938aa9a6f0066c17029773974b
Gerrit-Change-Number: 58045
Gerrit-PatchSet: 7
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Sun, 03 Oct 2021 02:29:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment