Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/20979 )
Change subject: nb/intel/x4x/raminit: Move dummy reads after JEDEC init
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
Now that I know a bit more about raminits, I can see what this patch is for, so LGTM.
It could use a rebase, though.
https://review.coreboot.org/c/coreboot/+/20979/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/20979/7//COMMIT_MSG@12
PS7, Line 12: Dummy reads also make much more sense after JEDEC init as a way to
: send a few JEDEC commands, presumably as a way to make sure it is
: ready.
Maybe we can get rid of those entirely?
The code does them for some reason, as they are also done on other platforms (gm45, for instance).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/20979
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8069f9c08ad5e5268ddbe3711d58bc42522f938c
Gerrit-Change-Number: 20979
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 10 Aug 2019 18:24:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment