Attention is currently required from: Michał Żygowski, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53991 )
Change subject: cpu/amd/agesa/family15tn/model_15_init.c: create correct MTRR solution
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Patchset:
PS3:
Dooesn't AGESA also do some MTRR programming? Is it still needed?
File src/cpu/amd/agesa/family15tn/model_15_init.c:
https://review.coreboot.org/c/coreboot/+/53991/comment/856daed8_6126e55c
PS3, Line 39: execution
`AGESA execution`?
I was wondering why Intel platforms don't need this. I suppose it's because AGESA is executed in-place, as opposed to post-RAM coreboot stages and blobs (refcode, FSP-S).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/53991
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3efcd4bb62953cae378e725d10a4b7e240dd4251
Gerrit-Change-Number: 53991
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 30 Nov 2021 12:24:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment