Attention is currently required from: V Sowmya, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, EricR Lai.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55831 )
Change subject: soc/intel/alderlake: Fix the typo for FSP_S_CONFIG variable
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55831/comment/04ea158a_ca6f7e21
PS2, Line 9: variable
param
Patchset:
PS1:
Can we merge this CL ASAP, it might break coreboot booting on master without this cl
It wouldn't really break booting because it is just a typo in param name in function pointer declaration and doesn't really impact build or boot. In fact, you can drop the param name completely too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55831
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0a9b500e528c68033008f3f8955d6c9c9ba8a737
Gerrit-Change-Number: 55831
Gerrit-PatchSet: 2
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 25 Jun 2021 05:28:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment