Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41029 )
Change subject: soc/intel/jasperlake: Add Sata related UPDs configuration
......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41029/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41029/4//COMMIT_MSG@11
PS4, Line 11: it can be set as per each board's requirement.
here in this we are changing FSP UPD value as per board's requirement. […]
can I mark it resolved ?
https://review.coreboot.org/c/coreboot/+/41029/6/src/soc/intel/jasperlake/fs...
File src/soc/intel/jasperlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/41029/6/src/soc/intel/jasperlake/fs...
PS6, Line 139: dev->enabled
Ack. will change this.
changed. can i mark it resolved?
https://review.coreboot.org/c/coreboot/+/41029/6/src/soc/intel/jasperlake/fs...
PS6, Line 140: SataEnable
Ack.
added all upds. can i mark it resolved ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41029
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f7e7508b8cd483508293ee3e7b760574d8f025f
Gerrit-Change-Number: 41029
Gerrit-PatchSet: 8
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 07 May 2020 12:43:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-MessageType: comment