Change in ...coreboot[master]: mainboard/intel/saddlebrook: add support for Saddle Brook - coreboot-gerrit

26 Feb 2019


      Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/21436 )
Change subject: mainboard/intel/saddlebrook: add support for Saddle Brook
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/#/c/21436/9/src/mainboard/intel/saddlebrook/roms... 
File src/mainboard/intel/saddlebrook/romstage.c:
https://review.coreboot.org/#/c/21436/9/src/mainboard/intel/saddlebrook/roms... 
PS9, Line 62: 	memory_params->MemorySpdPtr10 = (UINT32) blk.spd_array[2];
I believe this should have changed to spd_array[1] after blk.add_map was modified after patchset 7. I would asssume 2nd DIMM slot to currently not work.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/21436
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie221eb58e8ab8ff15e9ef19c1d145a5eb2921b4e
Gerrit-Change-Number: 21436
Gerrit-PatchSet: 9
Gerrit-Owner: Anuj Mittal anujx.mittal@intel.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Anuj Mittal anujx.mittal@intel.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: PraveenX Hodagatta Pranesh praveenx.hodagatta.pranesh@intel.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: Teo Boon Tiong boon.tiong.teo@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 26 Feb 2019 08:25:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment