Attention is currently required from: Angel Pons, Felix Singer, Michael Niewöhner, Michał Kopeć.
Maciej Pijanowski has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/62498?usp=email )
Change subject: mb/clevo/tgl-u: Add Clevo NV4x Tiger Lake laptop support
......................................................................
Patch Set 21:
(1 comment)
Patchset:
PS21:
I also don't like having more or less duplicates in the tree, but others have their own playground a […]
I do not think we care much about the names, and should be able to place the code under Clevo, with Kconfig for EC. We are also in favor of less code duplication in general. It is just how the current approach seemed like.
What might be more important, we might not have a strong desire to actually test much with the proprietary EC, as we will not be using it. As long as it will not be a problem, we should be fine with merging under Clevo.
Unless there will be some more technically justified differences, which Michał will explain here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62498?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib373d62d9d18bafdfde2e1acb4e00e3a20ae09bc
Gerrit-Change-Number: 62498
Gerrit-PatchSet: 21
Gerrit-Owner: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Wed, 19 Jun 2024 13:14:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de