Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42692 )
Change subject: soc/amd/common: Avoid aliasing on ACPIMMIO writes
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42692/4/src/soc/amd/common/block/in...
File src/soc/amd/common/block/include/amdblocks/acpimmio.h:
https://review.coreboot.org/c/coreboot/+/42692/4/src/soc/amd/common/block/in...
PS4, Line 242: return read8((void *)acpimmio_iomux + reg);
please do the cast after arithmetic
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42692
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7369b8b07a23e9b52c2961c527dc8d29ad4b505b
Gerrit-Change-Number: 42692
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 25 Jun 2020 06:01:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment