Attention is currently required from: Furquan Shaikh, Caveh Jalali, Tim Wawrzynczak. Matthew Blecker has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56928 )
Change subject: mb/google/poppy/variants/atlas: stop setting touchscreen probed=1 ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4: The Atlas touchscreen device has had generic.probed=1 since it was first added in https://review.coreboot.org/c/coreboot/+/27127 , however Caveh doesn't recall why (was 3 years ago). All Atlas have this touchscreen controller. Is there any reason to keep generic.probed=1?
Getting rid of generic.probed=1 (this CL) allows me to clean up the driver rebind sequence after touchscreen firmware update, which allows removing a hardcoded i2c_hid Linux driver name, which in turn completely avoids https://issuetracker.google.com/177350937 bug.
I vaguely recall noticing ~ 2 years ago that ACPI re-enumeration of this touchscreen controller didn't work, but I didn't do any digging for a fix, I just left in an existing workaround of hardcoding its Linux driver.