Attention is currently required from: Matt DeVillier.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84197?usp=email )
Change subject: drivers/i2c/generic: Remove erroneous acpigen_pop_len
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84197/comment/c7fec7fe_66ac1b51?usp... :
PS1, Line 1: Parent: b9a12911 (mb/lattepanda: Add support for LattePanda Mu)
I would add a note stating which commit the extra acpigen_pop_len() call was added, in gerrit's pref […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84197?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I913022144813f7f65eac1bcb7c97656f2c513c0b
Gerrit-Change-Number: 84197
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Tue, 03 Sep 2024 13:34:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com