Attention is currently required from: Subrata Banik, Selma Bensaid, Tim Wawrzynczak, Julius Werner, Patrick Rudolph. Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59507 )
Change subject: soc/intel/alderlake: Inject CSE TS into timestamp_table ......................................................................
Patch Set 12:
(4 comments)
File src/soc/intel/alderlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/59507/comment/d29f302f_6d026731 PS11, Line 164: cse_get_telemetry_data();
if (CONFIG(SOC_INTEL_CSE_PERFORMANCE_TELEMETRY)) […]
Done
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/59507/comment/d7d871e3_60262369 PS7, Line 121: USE_MBP_FOR_PRE_CPU_TELEMETRY
I don't think MBP now. […]
Done
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/59507/comment/702f53f8_b220fb51 PS11, Line 149: SOC_INTEL_CSE_PERFORMANCE_TELEMETRY
shouldn't we highlight as pre-cpu reset telemetry ?
sure, added it back
https://review.coreboot.org/c/coreboot/+/59507/comment/76a0963a_074e4660 PS11, Line 151: SOC_INTEL_CSE_LITE_SKU
are this feature only implemented for lite sku alone. […]
I believe consumer supports as well but I only validated lite sku.
-
Bora Guvendik (Code Review)