Attention is currently required from: Bob Moragues, Karthik Ramasubramanian, Shelley Chen.
Bob Moragues has posted comments on this change by Bob Moragues. ( https://review.coreboot.org/c/coreboot/+/82630?usp=email )
Change subject: mainboard/google/brox: Add FW_CONFIG and SKU definitions to support lotso ......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/brox/variants/brox/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/82630/comment/e64e7a6e_d24a9864?usp... : PS3, Line 19: option AUDIO_REALTEK_ALC3287 2
I don't think that you want this in brox. […]
I believe this was included to simply keep the the bit fields aligned between the brox reference design and lotso. I assume that this enumeration will not be used for brox. This can be removed at your discretion.
File src/mainboard/google/brox/variants/lotso/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/82630/comment/55e55b9a_19dc6b30?usp... : PS1, Line 31: hip soc/intel/alderlake : : device domain 0 on : end : : end Should this be removed?