Attention is currently required from: Paul Menzel, Shelley Chen, Subrata Banik.
Terry Cheong has posted comments on this change by Terry Cheong. ( https://review.coreboot.org/c/coreboot/+/82794?usp=email )
Change subject: mb/google/brox/var/brox: Enable Class-D calibration
......................................................................
Patch Set 7:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82794/comment/ec4d9253_c51cdab9?usp... :
PS2, Line 10: based
: on the updated verb table provided by Realtek
Included the bug and comment number as well.
Done
https://review.coreboot.org/c/coreboot/+/82794/comment/8eb65d4a_1a338ce8?usp... :
PS2, Line 15: TEST=Verify DC offset of speaker amplier is less than 3mV
How? And what value did you measure?
Actually it is DC offset value of the speaker output pins, we directly pull those out in hardware and measured with multimeter. Added description in the test field.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82794?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I776f5c24ce3c829cbd64840957c1431608cf2b85
Gerrit-Change-Number: 82794
Gerrit-PatchSet: 7
Gerrit-Owner: Terry Cheong
htcheong@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Vamshi Krishna Gopal
vamshi.krishna.gopal@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 31 Jul 2024 08:14:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Terry Cheong
htcheong@chromium.org