Attention is currently required from: Arthur Heymans.
Angel Pons has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84042?usp=email )
Change subject: soc/intel/pmclib.c: Make sure array_size is not 0 ......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/84042/comment/6b47ba43_8ec8c0e7?usp... : PS4, Line 351: printk(BIOS_DEBUG, "GPE0 STD STS: "); : : sts_arr = soc_std_gpe_sts_array(&array_size); : if (array_size == 0) : return 0; : print_num_status_bits(array_size, gpe_sts, sts_arr); : printk(BIOS_DEBUG, "\n"); I'd still print the newline so as not to mess up the formatting:
```suggestion printk(BIOS_DEBUG, "GPE0 STD STS: ");
sts_arr = soc_std_gpe_sts_array(&array_size); if (array_size > 0) print_num_status_bits(array_size, gpe_sts, sts_arr); printk(BIOS_DEBUG, "\n"); ```