Change in ...coreboot[master]: soc/intel/common: Add Kconfig option to choose desired MP Init for pl...
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30287 )
Change subject: soc/intel/common: Add Kconfig option to choose desired MP Init for platform ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/#/c/30287/10/src/soc/intel/common/block/cpu/Kcon... File src/soc/intel/common/block/cpu/Kconfig:
https://review.coreboot.org/#/c/30287/10/src/soc/intel/common/block/cpu/Kcon... PS10, Line 58: help
if we do that then we are limiting users not to select USE_INTEL_FSP_MP_INIT with !FSP2. […]
If this is to be user selectable, you need to add a title to this so it shows up in menuconfig etc. (and user overrides are honored when reading config files).
With that, you can add another line stating "default y if !PLATFORM_USES_FSP2_1" which gives a default that can still be overridden.
https://review.coreboot.org/#/c/30287/10/src/soc/intel/common/block/cpu/Kcon... PS10, Line 68: USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI that's quite a mouthful and I still don't know what it's supposed to do: install the PPI if this flag is enabled?
-
Patrick Georgi (Code Review)