Attention is currently required from: Chen Wisley, Wisley Chen, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58944 )
Change subject: soc/intel/alderlake: Add Acoustic noise mitigation UPDs ......................................................................
Patch Set 4:
(3 comments)
File src/soc/intel/alderlake/chip.h:
https://review.coreboot.org/c/coreboot/+/58944/comment/7e12ec00_3ec173b3 PS4, Line 546: * : * Enable or Disable Acoustic Noise Mitigation feature : */ nit: single-line comment will work here
https://review.coreboot.org/c/coreboot/+/58944/comment/95b9e697_1f85d08b PS4, Line 550: /* : * Disable Fast Slew Rate for Deep Package C States for VR domains : */ nit: single-line comment will work here
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/58944/comment/50be5d3e_f4c7743b PS4, Line 746: for (int i = 0; i < NUM_VR_DOMAINS; i++) { : s_cfg->FastPkgCRampDisable[i] = config->FastPkgCRampDisable[i]; : s_cfg->SlowSlewRate[i] = config->SlowSlewRate[i]; : } This should probably be guarded by `if (s_cfg->AcousticNoiseMitigation) {`