Change in coreboot[master]: mb/intel/kblrvp/var/baseboard: Relocate devicetree FSP settings

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43907 )

Change subject: mb/intel/kblrvp/var/baseboard: Relocate devicetree FSP settings
......................................................................

mb/intel/kblrvp/var/baseboard: Relocate devicetree FSP settings

Tested with BUILD_TIMELESS=1, Intel RVP7 does not change.

Change-Id: I12ad91ce9abad71f73b2183b2c8638a8af08f5b9
Signed-off-by: Angel Pons 
---
M src/mainboard/intel/kblrvp/variants/baseboard/devicetree.cb
1 file changed, 23 insertions(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/43907/1

diff --git a/src/mainboard/intel/kblrvp/variants/baseboard/devicetree.cb b/src/mainboard/intel/kblrvp/variants/baseboard/devicetree.cb
index b7e1cc0..898739c 100644
--- a/src/mainboard/intel/kblrvp/variants/baseboard/devicetree.cb
+++ b/src/mainboard/intel/kblrvp/variants/baseboard/devicetree.cb
@@ -23,12 +23,7 @@
    register "dptf_enable" = "1"

# FSP Configuration
-	register "SmbusEnable" = "1"
-	register "ScsEmmcEnabled" = "1"
-	register "ScsEmmcHs400Enabled" = "1"
-	register "ScsSdCardEnabled" = "2"
    register "SkipExtGfxScan" = "1"
-	register "Device4Enable" = "1"
    register "SaGv" = "SaGv_Enabled"
    register "PchHdaVcType" = "Vc1"

@@ -121,6 +116,10 @@
    device domain 0 on
    	device pci 00.0 on  end # Host Bridge
    	device pci 02.0 on  end # Integrated Graphics Device
+
+		# FIXME: corresponding device entry is missing
+		register "Device4Enable" = "1"
+
    	device pci 14.0 on  end # USB xHCI
    	device pci 14.1 off end # USB xDCI (OTG)
    	device pci 14.2 on  end # Thermal Subsystem
@@ -153,15 +152,29 @@
    	device pci 1e.1 off end # UART #1
    	device pci 1e.2 off end # GSPI #0
    	device pci 1e.3 off end # GSPI #1
-		device pci 1e.4 on  end # eMMC
+		device pci 1e.4 on      # eMMC
+			register "ScsEmmcEnabled" = "1"
+			register "ScsEmmcHs400Enabled" = "1"
+		end
    	device pci 1e.5 off end # SDIO
-		device pci 1e.6 on  end # SDCard
+		device pci 1e.6 on      # SDCard
+			register "ScsSdCardEnabled" = "2"
+		end
    	device pci 1f.0 on  end # LPC Interface
    	device pci 1f.1 on  end # P2SB
    	device pci 1f.2 on  end # Power Management Controller
-		device pci 1f.3 on  end # Intel HDA
-		device pci 1f.4 on  end # SMBus
+		device pci 1f.3 on      # Intel HDA
+
+			# FIXME: "EnableAzalia" is missing
+		end
+		device pci 1f.4 on      # SMBus
+			register "SmbusEnable" = "1"
+		end
    	device pci 1f.5 on  end # PCH SPI
-		device pci 1f.6 off end # GbE
+		device pci 1f.6 off     # GbE
+			register "EnableLan" = "0"
+		end
+
+		register "EnableTraceHub" = "0"
    end
 end

[Angel Pons (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43907

to look at the new patch set (#2).

Change subject: mb/intel/kblrvp/var/baseboard: Relocate devicetree FSP settings
......................................................................

mb/intel/kblrvp/var/baseboard: Relocate devicetree FSP settings

Tested with BUILD_TIMELESS=1, all four variants do not change.

Change-Id: I12ad91ce9abad71f73b2183b2c8638a8af08f5b9
Signed-off-by: Angel Pons 
---
M src/mainboard/intel/kblrvp/variants/baseboard/devicetree.cb
1 file changed, 23 insertions(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/43907/2

Change in coreboot[master]: mb/intel/kblrvp/var/baseboard: Relocate devicetree settings

[Angel Pons (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43907

to look at the new patch set (#3).

Change subject: mb/intel/kblrvp/var/baseboard: Relocate devicetree settings
......................................................................

mb/intel/kblrvp/var/baseboard: Relocate devicetree settings

Tested with BUILD_TIMELESS=1, all four variants do not change.

Change-Id: I12ad91ce9abad71f73b2183b2c8638a8af08f5b9
Signed-off-by: Angel Pons 
---
M src/mainboard/intel/kblrvp/variants/baseboard/devicetree.cb
1 file changed, 23 insertions(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/43907/3

Change in coreboot[master]: mb/intel/kblrvp/var/baseboard: Relocate devicetree settings

[Angel Pons (Code Review)]

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43907 )

Change subject: mb/intel/kblrvp/var/baseboard: Relocate devicetree settings
......................................................................

Abandoned