Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Hannah Williams, Jamie Ryu, Kapil Porwal, Pranava Y N, Ravishankar Sarawadi, Saurabh Mishra, Subrata Banik, Wonkyu Kim.
Paul Menzel has posted comments on this change by Ravishankar Sarawadi. ( https://review.coreboot.org/c/coreboot/+/83772?usp=email )
Change subject: soc/intel/ptl: Add SoC ACPI directory for Panther Lake
......................................................................
Patch Set 66:
(6 comments)
Patchset:
PS66:
How did you create the ASL files? Copy from some datasheet? Write from scratch?
Commit Message:
https://review.coreboot.org/c/coreboot/+/83772/comment/e55d4db5_79b2a50a?usp... :
PS66, Line 12: wake up
waking up or wakeup or wake-up
https://review.coreboot.org/c/coreboot/+/83772/comment/45185627_1ef34539?usp... :
PS66, Line 14: ,
Not needed.
https://review.coreboot.org/c/coreboot/+/83772/comment/cd4594e9_feec8213?usp... :
PS66, Line 16: gaurd
guard
https://review.coreboot.org/c/coreboot/+/83772/comment/8eb5f4a4_09c453d9?usp... :
PS66, Line 15: common/block/acpi/acpi/northbridge.asl binding with PTL change,
: #if DMI_BASE_SIZE gaurd check is added in northbridge.asl
Indent with one more space to align with above.?
File src/soc/intel/pantherlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/83772/comment/356449d2_9d165da2?usp... :
PS66, Line 7: Type C Subsystem(TCSS) topology provides Runtime D3 support for USB host controller(xHCI),
: * USB device controller(xDCI)
Please add a space before (.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83772?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia5cf899b049cb8eb27b4ea30c7f3ce7a14884f15
Gerrit-Change-Number: 83772
Gerrit-PatchSet: 66
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Appukuttan V K
appukuttan.vk@intel.com
Gerrit-CC: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-CC: Sanju Jose Thottan
sanjujose.thottan@intel.com
Gerrit-CC: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-CC: Vikrant L Jadeja
vikrant.l.jadeja@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Wed, 28 Aug 2024 08:27:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No