HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36265 )
Change subject: mb/google/{butterfly,link,parrot}: Drop wrong _ADR objects ......................................................................
mb/google/{butterfly,link,parrot}: Drop wrong _ADR objects
Use _HID but not _HID and _ADR at the same time.
Found-by: ACPICA 20191018 Change-Id: I8bcdfa7a4dc33c3e3866d3135249a602379b9615 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/butterfly/acpi/mainboard.asl M src/mainboard/google/link/acpi/mainboard.asl M src/mainboard/google/parrot/acpi/mainboard.asl 3 files changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/36265/1
diff --git a/src/mainboard/google/butterfly/acpi/mainboard.asl b/src/mainboard/google/butterfly/acpi/mainboard.asl index 4721f2a..2b1d637 100644 --- a/src/mainboard/google/butterfly/acpi/mainboard.asl +++ b/src/mainboard/google/butterfly/acpi/mainboard.asl @@ -29,7 +29,6 @@
Device (TPAD) { - Name (_ADR, 0x0) Name (_UID, 1)
// Report as a Sleep Button device so Linux will diff --git a/src/mainboard/google/link/acpi/mainboard.asl b/src/mainboard/google/link/acpi/mainboard.asl index 6a2d890..c153950 100644 --- a/src/mainboard/google/link/acpi/mainboard.asl +++ b/src/mainboard/google/link/acpi/mainboard.asl @@ -19,7 +19,6 @@ Scope (_SB) { Device (TPAD) { - Name (_ADR, 0x0) Name (_UID, 1)
// Report as a Sleep Button device so Linux will diff --git a/src/mainboard/google/parrot/acpi/mainboard.asl b/src/mainboard/google/parrot/acpi/mainboard.asl index 4906efc..8fe68c5 100644 --- a/src/mainboard/google/parrot/acpi/mainboard.asl +++ b/src/mainboard/google/parrot/acpi/mainboard.asl @@ -43,7 +43,6 @@
Device (TPAD) { - Name (_ADR, 0x0) Name (_UID, 1)
// Report as a Sleep Button device so Linux will
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36265
to look at the new patch set (#2).
Change subject: mb/google/{butterfly,link,parrot}: Drop wrong _ADR objects ......................................................................
mb/google/{butterfly,link,parrot}: Drop wrong _ADR objects
ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID object or an _ADR object, but should not contain both."
Found-by: ACPICA 20191018 Change-Id: I8bcdfa7a4dc33c3e3866d3135249a602379b9615 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/butterfly/acpi/mainboard.asl M src/mainboard/google/link/acpi/mainboard.asl M src/mainboard/google/parrot/acpi/mainboard.asl 3 files changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/36265/2
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36265 )
Change subject: mb/google/{butterfly,link,parrot}: Drop wrong _ADR objects ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36265 )
Change subject: mb/google/{butterfly,link,parrot}: Drop wrong _ADR objects ......................................................................
mb/google/{butterfly,link,parrot}: Drop wrong _ADR objects
ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID object or an _ADR object, but should not contain both."
Found-by: ACPICA 20191018 Change-Id: I8bcdfa7a4dc33c3e3866d3135249a602379b9615 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/36265 Reviewed-by: Duncan Laurie dlaurie@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/butterfly/acpi/mainboard.asl M src/mainboard/google/link/acpi/mainboard.asl M src/mainboard/google/parrot/acpi/mainboard.asl 3 files changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved
diff --git a/src/mainboard/google/butterfly/acpi/mainboard.asl b/src/mainboard/google/butterfly/acpi/mainboard.asl index 4721f2a..2b1d637 100644 --- a/src/mainboard/google/butterfly/acpi/mainboard.asl +++ b/src/mainboard/google/butterfly/acpi/mainboard.asl @@ -29,7 +29,6 @@
Device (TPAD) { - Name (_ADR, 0x0) Name (_UID, 1)
// Report as a Sleep Button device so Linux will diff --git a/src/mainboard/google/link/acpi/mainboard.asl b/src/mainboard/google/link/acpi/mainboard.asl index 6a2d890..c153950 100644 --- a/src/mainboard/google/link/acpi/mainboard.asl +++ b/src/mainboard/google/link/acpi/mainboard.asl @@ -19,7 +19,6 @@ Scope (_SB) { Device (TPAD) { - Name (_ADR, 0x0) Name (_UID, 1)
// Report as a Sleep Button device so Linux will diff --git a/src/mainboard/google/parrot/acpi/mainboard.asl b/src/mainboard/google/parrot/acpi/mainboard.asl index 4906efc..8fe68c5 100644 --- a/src/mainboard/google/parrot/acpi/mainboard.asl +++ b/src/mainboard/google/parrot/acpi/mainboard.asl @@ -43,7 +43,6 @@
Device (TPAD) { - Name (_ADR, 0x0) Name (_UID, 1)
// Report as a Sleep Button device so Linux will
-
Duncan Laurie (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)