HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31946
Change subject: Drop unused 'include <rtc.h>' ......................................................................
Drop unused 'include <rtc.h>'
Change-Id: I6577d9a31da44be5b57bb10497d9bd02fc9bbcd3 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/braswell/romstage/romstage.c M src/soc/mediatek/common/include/soc/rtc_common.h 2 files changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/31946/1
diff --git a/src/soc/intel/braswell/romstage/romstage.c b/src/soc/intel/braswell/romstage/romstage.c index e418064..8a4d8ab 100644 --- a/src/soc/intel/braswell/romstage/romstage.c +++ b/src/soc/intel/braswell/romstage/romstage.c @@ -44,7 +44,6 @@ #include <soc/smm.h> #include <soc/spi.h> #include <build.h> -#include <rtc.h> #include <pc80/mc146818rtc.h>
void program_base_addresses(void) diff --git a/src/soc/mediatek/common/include/soc/rtc_common.h b/src/soc/mediatek/common/include/soc/rtc_common.h index 41e772e..447ec14 100644 --- a/src/soc/mediatek/common/include/soc/rtc_common.h +++ b/src/soc/mediatek/common/include/soc/rtc_common.h @@ -20,7 +20,6 @@ #include <bcd.h> #include <console/console.h> #include <delay.h> -#include <rtc.h> #include <timer.h>
/*
Hello Patrick Rudolph, Julius Werner, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31946
to look at the new patch set (#2).
Change subject: soc/intel/braswell/romstage: Drop unused 'include <rtc.h>' ......................................................................
soc/intel/braswell/romstage: Drop unused 'include <rtc.h>'
Change-Id: I6577d9a31da44be5b57bb10497d9bd02fc9bbcd3 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/braswell/romstage/romstage.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/31946/2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31946 )
Change subject: soc/intel/braswell/romstage: Drop unused 'include <rtc.h>' ......................................................................
Patch Set 2: Code-Review+2
Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31946 )
Change subject: soc/intel/braswell/romstage: Drop unused 'include <rtc.h>' ......................................................................
soc/intel/braswell/romstage: Drop unused 'include <rtc.h>'
Change-Id: I6577d9a31da44be5b57bb10497d9bd02fc9bbcd3 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/31946 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/soc/intel/braswell/romstage/romstage.c 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved
diff --git a/src/soc/intel/braswell/romstage/romstage.c b/src/soc/intel/braswell/romstage/romstage.c index f749165..ca1eb40 100644 --- a/src/soc/intel/braswell/romstage/romstage.c +++ b/src/soc/intel/braswell/romstage/romstage.c @@ -43,7 +43,6 @@ #include <soc/smm.h> #include <soc/spi.h> #include <build.h> -#include <rtc.h> #include <pc80/mc146818rtc.h>
void program_base_addresses(void)
-
HAOUAS Elyes (Code Review) -
Kyösti Mälkki (Code Review)