Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/51919 )
Change subject: mb/prodrive/hermes: Drop Vref configuration for older boards ......................................................................
mb/prodrive/hermes: Drop Vref configuration for older boards
Drop Vref verbs from the baseboard table as it's not required for Rev. 3 and earlier.
Change-Id: I41c207f97dad6c9107c1999eb46d2d6304a6c217 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/51919 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Christian Walter christian.walter@9elements.com --- M src/mainboard/prodrive/hermes/variants/baseboard/hda_verb.c M src/mainboard/prodrive/hermes/variants/r04/hda_verb.c 2 files changed, 2 insertions(+), 14 deletions(-)
Approvals: build bot (Jenkins): Verified Christian Walter: Looks good to me, approved
diff --git a/src/mainboard/prodrive/hermes/variants/baseboard/hda_verb.c b/src/mainboard/prodrive/hermes/variants/baseboard/hda_verb.c index dc97794..0e5d359 100644 --- a/src/mainboard/prodrive/hermes/variants/baseboard/hda_verb.c +++ b/src/mainboard/prodrive/hermes/variants/baseboard/hda_verb.c @@ -6,21 +6,9 @@ const u32 cim_verb_data[] = { 0x10ec0888, /* Codec Vendor / Device ID: Realtek ALC888 */ 0x10ec0888, /* Subsystem ID */ - 17, /* Number of 4 dword sets */ + 15, /* Number of 4 dword sets */ AZALIA_SUBVENDOR(0, 0x10ec0888),
- /* Port configuration control */ - - 0x018707e1, /* port B VREF 50% of LDO-OUT */ - 0x019707e1, /* port F VREF 50% of LDO-OUT */ - 0x01b707e1, /* port E VREF 50% of LDO-OUT*/ - 0x0205000d, /* pin 37 vrefo hidden register - used as port C vref */ - - 0x02041000, /* pin 37 vrefo 50% of LDO-OUT */ - 0x02041000, /* Dummy entry */ - 0x02041000, /* Dummy entry */ - 0x02041000, /* Dummy entry */ - /* Pin widgets */ AZALIA_PIN_CFG(0, 0x11, 0x411111f0), /* SPDIF-OUT2 - disabled */ AZALIA_PIN_CFG(0, 0x12, 0x411111f0), /* digital MIC - disabled */ diff --git a/src/mainboard/prodrive/hermes/variants/r04/hda_verb.c b/src/mainboard/prodrive/hermes/variants/r04/hda_verb.c index ddb8661..f9a3cb3 100644 --- a/src/mainboard/prodrive/hermes/variants/r04/hda_verb.c +++ b/src/mainboard/prodrive/hermes/variants/r04/hda_verb.c @@ -66,7 +66,7 @@
const u32 verbs[] = { AZALIA_PIN_CFG(0, 0x1b, config), - 0x0205000d, + 0x0205000d, /* Pin 37 vrefo hidden register - used as port C vref */ get_port_c_vref_cfg(board_cfg->blue_rear_vref), }; azalia_program_verb_table(base, verbs, ARRAY_SIZE(verbs));