Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59857 )
Change subject: soc/intel/common/pch: Fix return value documentation for CHIPSET_LOCKDOWN ......................................................................
soc/intel/common/pch: Fix return value documentation for CHIPSET_LOCKDOWN
Fixed according to the declaration in soc/intel/common/block/include/intelblocks/cfg.h.
Change-Id: I50dbc00806fefda8f4dac8bfa21dc714a9504566 Signed-off-by: Jingle Hsu jingle_hsu@wiwynn.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/59857 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Johnny Lin Johnny_Lin@wiwynn.com Reviewed-by: Jonathan Zhang jonzhang@fb.com Reviewed-by: Felix Singer felixsinger@posteo.net Reviewed-by: Paul Menzel paulepanter@mailbox.org --- M src/soc/intel/common/pch/include/intelpch/lockdown.h M src/soc/intel/common/pch/lockdown/lockdown.c 2 files changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Felix Singer: Looks good to me, approved Jonathan Zhang: Looks good to me, approved Johnny Lin: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/common/pch/include/intelpch/lockdown.h b/src/soc/intel/common/pch/include/intelpch/lockdown.h index 22d7147..b5aba06 100644 --- a/src/soc/intel/common/pch/include/intelpch/lockdown.h +++ b/src/soc/intel/common/pch/include/intelpch/lockdown.h @@ -7,8 +7,8 @@ * This function will get lockdown config specific to soc. * * Return values: - * 0 = CHIPSET_LOCKDOWN_FSP = use FSP's lockdown functionality to lockdown IPs - * 1 = CHIPSET_LOCKDOWN_COREBOOT = Use coreboot to lockdown IPs + * 0 = CHIPSET_LOCKDOWN_COREBOOT = Use coreboot to lockdown IPs + * 1 = CHIPSET_LOCKDOWN_FSP = use FSP's lockdown functionality to lockdown IPs */ int get_lockdown_config(void);
diff --git a/src/soc/intel/common/pch/lockdown/lockdown.c b/src/soc/intel/common/pch/lockdown/lockdown.c index 374e3e6..5ab0611 100644 --- a/src/soc/intel/common/pch/lockdown/lockdown.c +++ b/src/soc/intel/common/pch/lockdown/lockdown.c @@ -14,8 +14,8 @@ * This function will get lockdown config specific to soc. * * Return values: - * 0 = CHIPSET_LOCKDOWN_FSP = use FSP's lockdown functionality to lockdown IPs - * 1 = CHIPSET_LOCKDOWN_COREBOOT = Use coreboot to lockdown IPs + * 0 = CHIPSET_LOCKDOWN_COREBOOT = Use coreboot to lockdown IPs + * 1 = CHIPSET_LOCKDOWN_FSP = use FSP's lockdown functionality to lockdown IPs */ int get_lockdown_config(void) {