[M] Change in coreboot[main]: acpi: Add IORT helper functions

[Naresh Solanki (Code Review)]

Attention is currently required from: Angel Pons, Arthur Heymans, Cliff Huang, Felix Held, Felix Singer, Lance Zhao, Patrick Rudolph, Tim Wawrzynczak.

Naresh Solanki has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/79404?usp=email )

Change subject: acpi: Add IORT helper functions
......................................................................

Patch Set 5:

(7 comments)

File src/acpi/acpi_iort.c:

https://review.coreboot.org/c/coreboot/+/79404/comment/7374ace4_9db72b76?usp... :
PS5, Line 9: 	acpi_iort_its_group_t *its_node_data;
> Any reason to declare this in advance?

Just want to keep all declaration in one place.

https://review.coreboot.org/c/coreboot/+/79404/comment/86a2a901_af1f98e7?usp... :
PS5, Line 11: 	*its = (acpi_iort_node_t *)current;
> This is an exported function, `*its` may be null. […]

Acknowledged

https://review.coreboot.org/c/coreboot/+/79404/comment/5196f204_bd82c022?usp... :
PS5, Line 36: 	*smmu_v3 = (acpi_iort_node_t *)current;
> Same here

Acknowledged

https://review.coreboot.org/c/coreboot/+/79404/comment/5f824a0f_60909e39?usp... :
PS5, Line 61: 	u16 device_name_len = strlen(device_name);
>

Acknowledged

https://review.coreboot.org/c/coreboot/+/79404/comment/0cdb583a_9ba3614f?usp... :
PS5, Line 63: 	*nc = (acpi_iort_node_t *)current;
> Same here

Acknowledged

https://review.coreboot.org/c/coreboot/+/79404/comment/2a94e478_3e6260f2?usp... :
PS5, Line 98: 	*rc = (acpi_iort_node_t *)current;
> Same here

Acknowledged

File src/include/acpi/acpi_iort.h:

https://review.coreboot.org/c/coreboot/+/79404/comment/360c03c7_9a64c0ba?usp... :
PS5, Line 113: /* ITS Group */
             : unsigned long its_entry(unsigned long current, acpi_iort_t *iort, acpi_iort_node_t **its,
             : 			u32 its_count, u32 *identifiers);
             : 
             : /* SMMUv3 */
             : unsigned long smmuv3_entry(unsigned long current, acpi_iort_t *iort, acpi_iort_node_t **smmu_v3,
             : 			   u64 base, u32 flags);
             : 
             : /* ID mapping */
             : unsigned long id_map_entry(unsigned long current, acpi_iort_node_t *node, u32 input_base,
             : 			   u32 id_count, u32 output_base, u32 output_reference, u32 flags);
             : 
             : /* Named Component */
             : unsigned long nc_entry(unsigned long current, acpi_iort_t *iort, acpi_iort_node_t **nc,
             : 		       u32 node_flags, u64 memory_properties, u32 memory_address_limit,
             : 		       char *device_name);
             : /* Root Complex */
             : unsigned long rc_entry(unsigned long current, acpi_iort_t *node, acpi_iort_node_t **rc,
             : 		       u64 memory_properties, u32 ats_attribute, u32 pci_segment_number,
             : 		       u8 memory_address_limit, u16 pasid_capabilities);
> I would add a namespace-like prefix to these functions, e.g. `its_entry` ---> `acpi_iort_its_entry`.

Acknowledged