Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48160 )
Change subject: mb/google/volteer: Add fw_config entries for boot device ......................................................................
mb/google/volteer: Add fw_config entries for boot device
Add the fw_config entries for the newly added boot device fields. These are added as separate fields since a board may have more than one selected.
BUG=b:173129299 TEST=abuild google/volteer
Change-Id: I2af9ffcf0b90d4f4b7f2f31613ee110d8f350454 Signed-off-by: Duncan Laurie dlaurie@google.com --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/48160/1
diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index 455b9ab..1b3b1cc 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -46,6 +46,18 @@ option KB_LAYOUT_DEFAULT 0 option KB_LAYOUT_1 1 end + field BOOT_DEVICE_EMMC 22 + option BOOT_EMMC_DISABLED 0 + option BOOT_EMMC_ENABLED 1 + end + field BOOT_DEVICE_NVME 23 + option BOOT_NVME_DISABLED 0 + option BOOT_NVME_ENABLED 1 + end + field BOOT_DEVICE_SATA 24 + option BOOT_SATA_DISABLED 0 + option BOOT_SATA_ENABLED 1 + end end
chip soc/intel/tigerlake
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48160 )
Change subject: mb/google/volteer: Add fw_config entries for boot device ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/48160/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48160/1/src/mainboard/google/voltee... PS1, Line 104: PcieRpEnable Ideally, we'd replace these with a pcie chip driver too, and then we could use fw_config to choose whether to configure PCIe ports for NVMe, SATA, etc.
https://review.coreboot.org/c/coreboot/+/48160/1/src/mainboard/google/voltee... PS1, Line 134: SataEnable" = "1" similar here.
Duncan Laurie has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48160 )
Change subject: mb/google/volteer: Add fw_config entries for boot device ......................................................................
mb/google/volteer: Add fw_config entries for boot device
Add the fw_config entries for the newly added boot device fields. These are added as separate fields since a board may have more than one selected.
BUG=b:173129299 TEST=abuild google/volteer
Change-Id: I2af9ffcf0b90d4f4b7f2f31613ee110d8f350454 Signed-off-by: Duncan Laurie dlaurie@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48160 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 12 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index 455b9ab..1b3b1cc 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -46,6 +46,18 @@ option KB_LAYOUT_DEFAULT 0 option KB_LAYOUT_1 1 end + field BOOT_DEVICE_EMMC 22 + option BOOT_EMMC_DISABLED 0 + option BOOT_EMMC_ENABLED 1 + end + field BOOT_DEVICE_NVME 23 + option BOOT_NVME_DISABLED 0 + option BOOT_NVME_ENABLED 1 + end + field BOOT_DEVICE_SATA 24 + option BOOT_SATA_DISABLED 0 + option BOOT_SATA_ENABLED 1 + end end
chip soc/intel/tigerlake
-
Duncan Laurie (Code Review) -
Tim Wawrzynczak (Code Review)