Attention is currently required from: Ravi kumar, Paul Menzel, Julius Werner.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49767 )
Change subject: soc/qualcomm: Commonize AOP firmware support
......................................................................
Patch Set 77:
(2 comments)
File src/soc/qualcomm/common/aop_load_reset.c:
https://review.coreboot.org/c/coreboot/+/49767/comment/fc852143_9114362f
PS77, Line 16: aop_fw_entry = selfload(&aop_fw_prog);
: if (!aop_fw_entry)
Can you fix this per feedback in CB:49392? Basically just have "if (!selfload(&aop_fw_prog))" ?
https://review.coreboot.org/c/coreboot/+/49767/comment/9e95093c_7c045e43
PS77, Line 22: \n
Please remove this newline.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49767
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90b0f48e15df390970e027bff2065b7a89b14cec
Gerrit-Change-Number: 49767
Gerrit-PatchSet: 77
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Tue, 12 Oct 2021 02:33:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment