HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31941
Change subject: src: Drop unused 'include <romstage_handoff.h>' ......................................................................
src: Drop unused 'include <romstage_handoff.h>'
Change-Id: I311269967949533264e44fd3bb29ad3a06056653 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/intel/bayleybay_fsp/romstage.c M src/mainboard/opencellular/elgon/romstage.c M src/mainboard/siemens/mc_tcu3/romstage.c M src/soc/intel/braswell/romstage/romstage.c M src/soc/intel/braswell/southcluster.c M src/soc/intel/denverton_ns/systemagent.c M src/soc/intel/fsp_broadwell_de/ramstage.c M src/soc/intel/fsp_broadwell_de/romstage/romstage.c M src/soc/intel/fsp_broadwell_de/southcluster.c M src/soc/intel/skylake/romstage/romstage.c 10 files changed, 0 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/31941/1
diff --git a/src/mainboard/intel/bayleybay_fsp/romstage.c b/src/mainboard/intel/bayleybay_fsp/romstage.c index 0b8c16b..a6ccd96 100644 --- a/src/mainboard/intel/bayleybay_fsp/romstage.c +++ b/src/mainboard/intel/bayleybay_fsp/romstage.c @@ -17,7 +17,6 @@ #include <stddef.h> #include <arch/cbfs.h> #include <cpu/x86/mtrr.h> -#include <romstage_handoff.h> #include <soc/gpio.h> #include <soc/iomap.h> #include <soc/lpc.h> diff --git a/src/mainboard/opencellular/elgon/romstage.c b/src/mainboard/opencellular/elgon/romstage.c index 1b64765..8456e2d 100644 --- a/src/mainboard/opencellular/elgon/romstage.c +++ b/src/mainboard/opencellular/elgon/romstage.c @@ -16,7 +16,6 @@
#include <arch/exception.h> #include <cbmem.h> -#include <romstage_handoff.h> #include <soc/sdram.h> #include <soc/timer.h> #include <soc/mmu.h> diff --git a/src/mainboard/siemens/mc_tcu3/romstage.c b/src/mainboard/siemens/mc_tcu3/romstage.c index 3c36833..41d0d04 100644 --- a/src/mainboard/siemens/mc_tcu3/romstage.c +++ b/src/mainboard/siemens/mc_tcu3/romstage.c @@ -18,7 +18,6 @@ #include <arch/cbfs.h> #include <console/console.h> #include <cpu/x86/mtrr.h> -#include <romstage_handoff.h> #include <soc/gpio.h> #include <soc/iomap.h> #include <soc/lpc.h> diff --git a/src/soc/intel/braswell/romstage/romstage.c b/src/soc/intel/braswell/romstage/romstage.c index e418064..f749165 100644 --- a/src/soc/intel/braswell/romstage/romstage.c +++ b/src/soc/intel/braswell/romstage/romstage.c @@ -29,7 +29,6 @@ #include <device/pci_def.h> #include <elog.h> #include <mrc_cache.h> -#include <romstage_handoff.h> #include <string.h> #include <timestamp.h> #include <reset.h> diff --git a/src/soc/intel/braswell/southcluster.c b/src/soc/intel/braswell/southcluster.c index dc204f3..f389084 100644 --- a/src/soc/intel/braswell/southcluster.c +++ b/src/soc/intel/braswell/southcluster.c @@ -30,7 +30,6 @@ #include <pc80/isa-dma.h> #include <pc80/i8254.h> #include <pc80/i8259.h> -#include <romstage_handoff.h> #include <soc/acpi.h> #include <soc/iomap.h> #include <soc/irq.h> diff --git a/src/soc/intel/denverton_ns/systemagent.c b/src/soc/intel/denverton_ns/systemagent.c index dbcc51a..e715469 100644 --- a/src/soc/intel/denverton_ns/systemagent.c +++ b/src/soc/intel/denverton_ns/systemagent.c @@ -25,7 +25,6 @@ #include <device/pci_ids.h> #include <stdlib.h> #include <string.h> -#include <romstage_handoff.h> #include <timer.h>
#include <soc/iomap.h> diff --git a/src/soc/intel/fsp_broadwell_de/ramstage.c b/src/soc/intel/fsp_broadwell_de/ramstage.c index a64e337..96b3888 100644 --- a/src/soc/intel/fsp_broadwell_de/ramstage.c +++ b/src/soc/intel/fsp_broadwell_de/ramstage.c @@ -23,7 +23,6 @@ #include <device/device.h> #include <device/pci_def.h> #include <device/pci_ops.h> -#include <romstage_handoff.h> #include <soc/lpc.h> #include <soc/msr.h> #include <soc/pattrs.h> diff --git a/src/soc/intel/fsp_broadwell_de/romstage/romstage.c b/src/soc/intel/fsp_broadwell_de/romstage/romstage.c index 32429ae..36e9e6b 100644 --- a/src/soc/intel/fsp_broadwell_de/romstage/romstage.c +++ b/src/soc/intel/fsp_broadwell_de/romstage/romstage.c @@ -24,7 +24,6 @@ #include <console/usb.h> #include <cpu/x86/mtrr.h> #include <program_loading.h> -#include <romstage_handoff.h> #include <timestamp.h> #include <version.h> #include <drivers/intel/fsp1_0/fsp_util.h> diff --git a/src/soc/intel/fsp_broadwell_de/southcluster.c b/src/soc/intel/fsp_broadwell_de/southcluster.c index 5b90bbb..a1e183a 100644 --- a/src/soc/intel/fsp_broadwell_de/southcluster.c +++ b/src/soc/intel/fsp_broadwell_de/southcluster.c @@ -27,7 +27,6 @@ #include <pc80/i8254.h> #include <pc80/i8259.h> #include <pc80/isa-dma.h> -#include <romstage_handoff.h> #include <soc/iomap.h> #include <soc/irq.h> #include <soc/lpc.h> diff --git a/src/soc/intel/skylake/romstage/romstage.c b/src/soc/intel/skylake/romstage/romstage.c index dc9c528..ac43c27 100644 --- a/src/soc/intel/skylake/romstage/romstage.c +++ b/src/soc/intel/skylake/romstage/romstage.c @@ -27,7 +27,6 @@ #include <intelblocks/fast_spi.h> #include <intelblocks/pmclib.h> #include <reset.h> -#include <romstage_handoff.h> #include <soc/pci_devs.h> #include <soc/pei_wrapper.h> #include <soc/pm.h>
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31941 )
Change subject: src: Drop unused 'include <romstage_handoff.h>' ......................................................................
Patch Set 1: Code-Review+2
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31941 )
Change subject: src: Drop unused 'include <romstage_handoff.h>' ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31941 )
Change subject: src: Drop unused 'include <romstage_handoff.h>' ......................................................................
src: Drop unused 'include <romstage_handoff.h>'
Change-Id: I311269967949533264e44fd3bb29ad3a06056653 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/31941 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Werner Zeh werner.zeh@siemens.com --- M src/mainboard/intel/bayleybay_fsp/romstage.c M src/mainboard/opencellular/elgon/romstage.c M src/mainboard/siemens/mc_tcu3/romstage.c M src/soc/intel/braswell/romstage/romstage.c M src/soc/intel/braswell/southcluster.c M src/soc/intel/denverton_ns/systemagent.c M src/soc/intel/fsp_broadwell_de/ramstage.c M src/soc/intel/fsp_broadwell_de/romstage/romstage.c M src/soc/intel/fsp_broadwell_de/southcluster.c M src/soc/intel/skylake/romstage/romstage.c 10 files changed, 0 insertions(+), 10 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Werner Zeh: Looks good to me, approved
diff --git a/src/mainboard/intel/bayleybay_fsp/romstage.c b/src/mainboard/intel/bayleybay_fsp/romstage.c index 0b8c16b..a6ccd96 100644 --- a/src/mainboard/intel/bayleybay_fsp/romstage.c +++ b/src/mainboard/intel/bayleybay_fsp/romstage.c @@ -17,7 +17,6 @@ #include <stddef.h> #include <arch/cbfs.h> #include <cpu/x86/mtrr.h> -#include <romstage_handoff.h> #include <soc/gpio.h> #include <soc/iomap.h> #include <soc/lpc.h> diff --git a/src/mainboard/opencellular/elgon/romstage.c b/src/mainboard/opencellular/elgon/romstage.c index 1b64765..8456e2d 100644 --- a/src/mainboard/opencellular/elgon/romstage.c +++ b/src/mainboard/opencellular/elgon/romstage.c @@ -16,7 +16,6 @@
#include <arch/exception.h> #include <cbmem.h> -#include <romstage_handoff.h> #include <soc/sdram.h> #include <soc/timer.h> #include <soc/mmu.h> diff --git a/src/mainboard/siemens/mc_tcu3/romstage.c b/src/mainboard/siemens/mc_tcu3/romstage.c index 3c36833..41d0d04 100644 --- a/src/mainboard/siemens/mc_tcu3/romstage.c +++ b/src/mainboard/siemens/mc_tcu3/romstage.c @@ -18,7 +18,6 @@ #include <arch/cbfs.h> #include <console/console.h> #include <cpu/x86/mtrr.h> -#include <romstage_handoff.h> #include <soc/gpio.h> #include <soc/iomap.h> #include <soc/lpc.h> diff --git a/src/soc/intel/braswell/romstage/romstage.c b/src/soc/intel/braswell/romstage/romstage.c index e418064..f749165 100644 --- a/src/soc/intel/braswell/romstage/romstage.c +++ b/src/soc/intel/braswell/romstage/romstage.c @@ -29,7 +29,6 @@ #include <device/pci_def.h> #include <elog.h> #include <mrc_cache.h> -#include <romstage_handoff.h> #include <string.h> #include <timestamp.h> #include <reset.h> diff --git a/src/soc/intel/braswell/southcluster.c b/src/soc/intel/braswell/southcluster.c index dc204f3..f389084 100644 --- a/src/soc/intel/braswell/southcluster.c +++ b/src/soc/intel/braswell/southcluster.c @@ -30,7 +30,6 @@ #include <pc80/isa-dma.h> #include <pc80/i8254.h> #include <pc80/i8259.h> -#include <romstage_handoff.h> #include <soc/acpi.h> #include <soc/iomap.h> #include <soc/irq.h> diff --git a/src/soc/intel/denverton_ns/systemagent.c b/src/soc/intel/denverton_ns/systemagent.c index dbcc51a..e715469 100644 --- a/src/soc/intel/denverton_ns/systemagent.c +++ b/src/soc/intel/denverton_ns/systemagent.c @@ -25,7 +25,6 @@ #include <device/pci_ids.h> #include <stdlib.h> #include <string.h> -#include <romstage_handoff.h> #include <timer.h>
#include <soc/iomap.h> diff --git a/src/soc/intel/fsp_broadwell_de/ramstage.c b/src/soc/intel/fsp_broadwell_de/ramstage.c index a64e337..96b3888 100644 --- a/src/soc/intel/fsp_broadwell_de/ramstage.c +++ b/src/soc/intel/fsp_broadwell_de/ramstage.c @@ -23,7 +23,6 @@ #include <device/device.h> #include <device/pci_def.h> #include <device/pci_ops.h> -#include <romstage_handoff.h> #include <soc/lpc.h> #include <soc/msr.h> #include <soc/pattrs.h> diff --git a/src/soc/intel/fsp_broadwell_de/romstage/romstage.c b/src/soc/intel/fsp_broadwell_de/romstage/romstage.c index 32429ae..36e9e6b 100644 --- a/src/soc/intel/fsp_broadwell_de/romstage/romstage.c +++ b/src/soc/intel/fsp_broadwell_de/romstage/romstage.c @@ -24,7 +24,6 @@ #include <console/usb.h> #include <cpu/x86/mtrr.h> #include <program_loading.h> -#include <romstage_handoff.h> #include <timestamp.h> #include <version.h> #include <drivers/intel/fsp1_0/fsp_util.h> diff --git a/src/soc/intel/fsp_broadwell_de/southcluster.c b/src/soc/intel/fsp_broadwell_de/southcluster.c index 5b90bbb..a1e183a 100644 --- a/src/soc/intel/fsp_broadwell_de/southcluster.c +++ b/src/soc/intel/fsp_broadwell_de/southcluster.c @@ -27,7 +27,6 @@ #include <pc80/i8254.h> #include <pc80/i8259.h> #include <pc80/isa-dma.h> -#include <romstage_handoff.h> #include <soc/iomap.h> #include <soc/irq.h> #include <soc/lpc.h> diff --git a/src/soc/intel/skylake/romstage/romstage.c b/src/soc/intel/skylake/romstage/romstage.c index dc9c528..ac43c27 100644 --- a/src/soc/intel/skylake/romstage/romstage.c +++ b/src/soc/intel/skylake/romstage/romstage.c @@ -27,7 +27,6 @@ #include <intelblocks/fast_spi.h> #include <intelblocks/pmclib.h> #include <reset.h> -#include <romstage_handoff.h> #include <soc/pci_devs.h> #include <soc/pei_wrapper.h> #include <soc/pm.h>
-
HAOUAS Elyes (Code Review) -
Kyösti Mälkki (Code Review)
-
Werner Zeh (Code Review)