Attention is currently required from: Hung-Te Lin, Paul Menzel, Xi Chen, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83988?usp=email )
Change subject: soc/mediatek/common: Move GPIO definition to the common directory ......................................................................
Patch Set 3:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83988/comment/4bfb3f06_11162937?usp... : PS1, Line 7: definations
defin*i*tions
Done
https://review.coreboot.org/c/coreboot/+/83988/comment/3b0f209d_73b1cbf4?usp... : PS1, Line 7: soc/mediatek: Move GPIO definations to MediaTek common directory
soc/mediatek/common: Move GPIO definition to the common folder
Done
https://review.coreboot.org/c/coreboot/+/83988/comment/d14ada3e_b0961e8d?usp... : PS1, Line 9: reduece
reduce
Done
https://review.coreboot.org/c/coreboot/+/83988/comment/4da62e4f_8fafe29d?usp... : PS1, Line 9: definations
definitions
Done
https://review.coreboot.org/c/coreboot/+/83988/comment/a791d515_d12fef63?usp... : PS1, Line 10: definations
Ditto.
Done
File src/soc/mediatek/mt8173/include/soc/gpio_base.h:
https://review.coreboot.org/c/coreboot/+/83988/comment/b9b37d78_92d45a2c?usp... : PS1, Line 7: typedef struct { : u32 id; : } gpio_t;
Will this be compatible with the common files? (Sorry, no C expert. […]
Please refer to https://review.coreboot.org/c/coreboot/+/83922/comment/1bfa31b1_f80680fe/