Change in coreboot[master]: mb/google/trogdor: Adjust mipi panel backlight gpio - coreboot-gerrit

15 Nov 2021


      Attention is currently required from: zanxi chen.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59044 )
Change subject: mb/google/trogdor: Adjust mipi panel backlight gpio
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/59044/comment/b2dc4ff9_cdf0cc76 
PS5, Line 145: 	if (CONFIG(BOARD_GOOGLE_MRBLAND) || CONFIG(BOARD_GOOGLE_WORMDINGLER))
...
Thanks, Julius. […]
Yes, do use TROGDOR_HAS_MIPI_PANEL. All these boards should have the same layout. (If we later find out they don't we'll have to address that, but until we do let's assume we did it the right way.)
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59044
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9920e5366f6b1ea9e0da228bd211317516b390a
Gerrit-Change-Number: 59044
Gerrit-PatchSet: 6
Gerrit-Owner: zanxi chen chenzanxi@huaqin.corp-partner.google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: xuxinxiong xuxinxiong@huaqin.corp-partner.google.com
Gerrit-CC: Weimin Wu wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: zanxi chen chenzanxi@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Mon, 15 Nov 2021 18:47:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: zanxi chen chenzanxi@huaqin.corp-partner.google.com
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment