Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43924 )
Change subject: mb/intel/cedarisland: Remove dublicated code
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43924/4/src/mainboard/intel/cedaris...
File src/mainboard/intel/cedarisland_crb/romstage.c:
https://review.coreboot.org/c/coreboot/+/43924/4/src/mainboard/intel/cedaris...
PS4, Line 10: m_cfg->KtiLinkSpeedMode = 0;
nit: Should we set this everywhere? Or even drop it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43924
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic79245103c33427e06c7ea881be778e3d219c45f
Gerrit-Change-Number: 43924
Gerrit-PatchSet: 4
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 27 Jul 2020 17:05:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment