Attention is currently required from: Frank Wu, Furquan Shaikh, Martin Roth, Tim Wawrzynczak.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51051 )
Change subject: drivers/generic/alc1015: add ALC1015 AMP driver
......................................................................
Patch Set 5:
(5 comments)
File src/drivers/generic/alc1015/Kconfig:
https://review.coreboot.org/c/coreboot/+/51051/comment/53efa69d_d6532c88
PS5, Line 3:
SG!
Done
File src/drivers/generic/alc1015/alc1015.c:
https://review.coreboot.org/c/coreboot/+/51051/comment/48f1a052_50b985b1
PS5, Line 8: #include <gpio.h>
no need.
Done
https://review.coreboot.org/c/coreboot/+/51051/comment/04b797e2_ad96d6ed
PS5, Line 13: ALC1015_ACPI_NAME
I can return name without define :p
Done
https://review.coreboot.org/c/coreboot/+/51051/comment/4bc15df5_e03aef2b
PS5, Line 54: config->sdb.active_low);
oh, yes. one line can fit 96 char.
Done
File src/drivers/generic/alc1015/chip.h:
https://review.coreboot.org/c/coreboot/+/51051/comment/95716671_1685b264
PS5, Line 7: hid
I think this is only one HID. Kernel UPSTREAM is on going. I can wait the final name.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51051
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id93845024aa2cded69acc88d594c222f2f821f79
Gerrit-Change-Number: 51051
Gerrit-PatchSet: 5
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 02 Mar 2021 03:42:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment