Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43924 )
Change subject: mb/intel/cedarisland: Remove duplicated code ......................................................................
Patch Set 5: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/43924/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43924/4//COMMIT_MSG@7 PS4, Line 7: dublicated
du*p*licated
Done
https://review.coreboot.org/c/coreboot/+/43924/4//COMMIT_MSG@9 PS4, Line 9: xeon_sp/cpx/romstage.c
I'd wrap the filename in backticks or some quotes: `xeon_sp/cpx/romstage. […]
Done
https://review.coreboot.org/c/coreboot/+/43924/4//COMMIT_MSG@9 PS4, Line 9: the
drop `the`
Done