Yan Liu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43441 )
Change subject: src/soc/intel/common/hda: support audio jack for Boten ......................................................................
src/soc/intel/common/hda: support audio jack for Boten
Add HDA ID for Jasperlake
BUG=b:160651126 BRANCH=NONE TEST=Add PCI ID to hda.c for boten
Signed-off-by: Yan Liu yan.liu@bitland.corp-partner.google.com Change-Id: Ib62c332d8d87201b3e6903251d824e1c3e06cd68 --- M src/soc/intel/common/block/hda/hda.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/43441/1
diff --git a/src/soc/intel/common/block/hda/hda.c b/src/soc/intel/common/block/hda/hda.c index c84415f..ec70f52 100644 --- a/src/soc/intel/common/block/hda/hda.c +++ b/src/soc/intel/common/block/hda/hda.c @@ -71,6 +71,7 @@ PCI_DEVICE_ID_INTEL_BSW_AUDIO, PCI_DEVICE_ID_INTEL_TGL_AUDIO, PCI_DEVICE_ID_INTEL_MCC_AUDIO, + PCI_DEVICE_ID_INTEL_JSP_AUDIO, 0 };
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43441 )
Change subject: src/soc/intel/common/hda: support audio jack for Boten ......................................................................
Patch Set 1: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43441 )
Change subject: src/soc/intel/common/hda: support audio jack for Boten ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43441/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43441/1//COMMIT_MSG@7 PS1, Line 7: src/ Please remove `src/` from the prefix.
https://review.coreboot.org/c/coreboot/+/43441/1//COMMIT_MSG@7 PS1, Line 7: support audio jack for Boten Maybe your text from the commit message body:
Add HDA ID for Jasper Lake
https://review.coreboot.org/c/coreboot/+/43441/1//COMMIT_MSG@9 PS1, Line 9: Add HDA ID for Jasperlake Maybe:
Currently, audio is not working on Boten, caused by the corebood HDA driver not being run as the Jasper Lake PCI ID is missing. So, add the Jasper Lake ID.
https://review.coreboot.org/c/coreboot/+/43441/1//COMMIT_MSG@13 PS1, Line 13: TEST=Add PCI ID to hda.c for boten Maybe:
Connect speaker to audio jack, and verify sound is played.
Hello build bot (Jenkins), Marco Chen, Peichao Li, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43441
to look at the new patch set (#2).
Change subject: soc/intel/common/hda: Add HDA ID for Jasper Lake ......................................................................
soc/intel/common/hda: Add HDA ID for Jasper Lake
Currently, audio is not working on Boten, caused by the coreboot HDA driver not being run as the Jasper Lake PCI ID is missing. So, add the Jasper Lake ID.
BUG=b:160651126 BRANCH=NONE TEST=Connect speaker to audio jack, and verify sound is played.
Signed-off-by: Yan Liu yan.liu@bitland.corp-partner.google.com Change-Id: Ib62c332d8d87201b3e6903251d824e1c3e06cd68 --- M src/soc/intel/common/block/hda/hda.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/43441/2
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43441 )
Change subject: soc/intel/common/hda: Add HDA ID for Jasper Lake ......................................................................
Patch Set 2: Code-Review+2
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43441 )
Change subject: soc/intel/common/hda: Add HDA ID for Jasper Lake ......................................................................
Patch Set 2: Code-Review+2
(4 comments)
https://review.coreboot.org/c/coreboot/+/43441/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43441/1//COMMIT_MSG@7 PS1, Line 7: support audio jack for Boten
Maybe your text from the commit message body: […]
Done
https://review.coreboot.org/c/coreboot/+/43441/1//COMMIT_MSG@7 PS1, Line 7: src/
Please remove `src/` from the prefix.
Done
https://review.coreboot.org/c/coreboot/+/43441/1//COMMIT_MSG@9 PS1, Line 9: Add HDA ID for Jasperlake
Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/43441/1//COMMIT_MSG@13 PS1, Line 13: TEST=Add PCI ID to hda.c for boten
Maybe: […]
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43441 )
Change subject: soc/intel/common/hda: Add HDA ID for Jasper Lake ......................................................................
soc/intel/common/hda: Add HDA ID for Jasper Lake
Currently, audio is not working on Boten, caused by the coreboot HDA driver not being run as the Jasper Lake PCI ID is missing. So, add the Jasper Lake ID.
BUG=b:160651126 BRANCH=NONE TEST=Connect speaker to audio jack, and verify sound is played.
Signed-off-by: Yan Liu yan.liu@bitland.corp-partner.google.com Change-Id: Ib62c332d8d87201b3e6903251d824e1c3e06cd68 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43441 Reviewed-by: Justin TerAvest teravest@chromium.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Peichao Li peichao.wang@bitland.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/common/block/hda/hda.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Justin TerAvest: Looks good to me, approved Peichao Li: Looks good to me, but someone else must approve Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/soc/intel/common/block/hda/hda.c b/src/soc/intel/common/block/hda/hda.c index c84415f..ec70f52 100644 --- a/src/soc/intel/common/block/hda/hda.c +++ b/src/soc/intel/common/block/hda/hda.c @@ -71,6 +71,7 @@ PCI_DEVICE_ID_INTEL_BSW_AUDIO, PCI_DEVICE_ID_INTEL_TGL_AUDIO, PCI_DEVICE_ID_INTEL_MCC_AUDIO, + PCI_DEVICE_ID_INTEL_JSP_AUDIO, 0 };
-
Justin TerAvest (Code Review) -
Karthik Ramasubramanian (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Peichao Li (Code Review)
-
Yan Liu (Code Review)