[XS] Change in coreboot[master]: acpi/acpigen.c: Ignore compiler warning about stack overflowing - coreboot-gerrit

23 Jun 2023


      Attention is currently required from: Arthur Heymans, Felix Held, Lance Zhao, Paul Menzel, Tim Wawrzynczak.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76007?usp=email )
Change subject: acpi/acpigen.c: Ignore compiler warning about stack overflowing
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: 
Looks like we are using __builtin_alloca() (commonlib). GCC manual states
that stack will be used and a simple variable-length array would be preferred.
I've looked into callers, at most 9 callbacks/bits are used, so it seems
safe either way.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/76007?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d445d151db5e6cc7b6e13bf74ce81007d819f1d
Gerrit-Change-Number: 76007
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com
Gerrit-Reviewer: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao lance.zhao@gmail.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 23 Jun 2023 12:41:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment