Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43514 )
Change subject: soc/amd/picasso: Move PMOD global variable to globalnvs.asl ......................................................................
soc/amd/picasso: Move PMOD global variable to globalnvs.asl
Global variable `PMOD` that stores the interrupt mode used by OS is required by all mainboards. This change moves the variable definition to globalnvs.asl under picasso.
Additionally, ACPI spec says that BIOS should assume interrupt mode as PIC until _PIC() method is called by OS. Thus, this change also updates the default value of PMOD as 0 i.e. PIC mode.
BUG=b:153879530
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I731c03d965882281a7a23f55894451210ba72274 --- M src/mainboard/amd/mandolin/acpi/mainboard.asl M src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/mainboard.asl M src/soc/amd/picasso/acpi/globalnvs.asl 3 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/43514/1
diff --git a/src/mainboard/amd/mandolin/acpi/mainboard.asl b/src/mainboard/amd/mandolin/acpi/mainboard.asl index d59240b..534155e 100644 --- a/src/mainboard/amd/mandolin/acpi/mainboard.asl +++ b/src/mainboard/amd/mandolin/acpi/mainboard.asl @@ -12,4 +12,3 @@ /* Some global data */ Name(OSVR, 3) /* Assume nothing. WinXp = 1, Vista = 2, Linux = 3, WinCE = 4 */ Name(OSV, Ones) /* Assume nothing */ -Name(PMOD, One) /* Assume APIC */ diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/mainboard.asl b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/mainboard.asl index b3d3996..e778970 100644 --- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/mainboard.asl +++ b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/mainboard.asl @@ -12,4 +12,3 @@ /* Some global data */ Name(OSVR, 3) /* Assume nothing. WinXp = 1, Vista = 2, Linux = 3, WinCE = 4 */ Name(OSV, Ones) /* Assume nothing */ -Name(PMOD, One) /* Assume APIC */ diff --git a/src/soc/amd/picasso/acpi/globalnvs.asl b/src/soc/amd/picasso/acpi/globalnvs.asl index 3ab35df..8147619 100644 --- a/src/soc/amd/picasso/acpi/globalnvs.asl +++ b/src/soc/amd/picasso/acpi/globalnvs.asl @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
+/* Global variables */ +Name (PMOD, Zero) /* Interrupt Mode used by OS. Assume PIC. */ + /* * NOTE: The layout of the GNVS structure below must match the layout in * soc/amd/picasso/include/soc/nvs.h !!!
Furquan Shaikh has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/43514 )
Change subject: soc/amd/picasso: Move PMOD global variable to globalnvs.asl ......................................................................
soc/amd/picasso: Move PMOD global variable to globalnvs.asl
Global variable `PMOD` that stores the interrupt mode used by OS is required by all mainboards. This change moves the variable definition to globalnvs.asl under picasso.
Additionally, ACPI spec says that BIOS should assume interrupt mode as PIC until _PIC() method is called by OS. Thus, this change also updates the default value of PMOD as 0 i.e. PIC mode.
BUG=b:153879530
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I731c03d965882281a7a23f55894451210ba72274 --- M src/mainboard/amd/mandolin/acpi/mainboard.asl M src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/mainboard.asl M src/soc/amd/picasso/acpi/globalnvs.asl 3 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/43514/2
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43514 )
Change subject: soc/amd/picasso: Move PMOD global variable to globalnvs.asl ......................................................................
Patch Set 2: Code-Review+2
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43514 )
Change subject: soc/amd/picasso: Move PMOD global variable to globalnvs.asl ......................................................................
Patch Set 2: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43514 )
Change subject: soc/amd/picasso: Move PMOD global variable to globalnvs.asl ......................................................................
soc/amd/picasso: Move PMOD global variable to globalnvs.asl
Global variable `PMOD` that stores the interrupt mode used by OS is required by all mainboards. This change moves the variable definition to globalnvs.asl under picasso.
Additionally, ACPI spec says that BIOS should assume interrupt mode as PIC until _PIC() method is called by OS. Thus, this change also updates the default value of PMOD as 0 i.e. PIC mode.
BUG=b:153879530
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I731c03d965882281a7a23f55894451210ba72274 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43514 Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/amd/mandolin/acpi/mainboard.asl M src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/mainboard.asl M src/soc/amd/picasso/acpi/globalnvs.asl 3 files changed, 3 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Raul Rangel: Looks good to me, approved
diff --git a/src/mainboard/amd/mandolin/acpi/mainboard.asl b/src/mainboard/amd/mandolin/acpi/mainboard.asl index d59240b..534155e 100644 --- a/src/mainboard/amd/mandolin/acpi/mainboard.asl +++ b/src/mainboard/amd/mandolin/acpi/mainboard.asl @@ -12,4 +12,3 @@ /* Some global data */ Name(OSVR, 3) /* Assume nothing. WinXp = 1, Vista = 2, Linux = 3, WinCE = 4 */ Name(OSV, Ones) /* Assume nothing */ -Name(PMOD, One) /* Assume APIC */ diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/mainboard.asl b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/mainboard.asl index b3d3996..e778970 100644 --- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/mainboard.asl +++ b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/mainboard.asl @@ -12,4 +12,3 @@ /* Some global data */ Name(OSVR, 3) /* Assume nothing. WinXp = 1, Vista = 2, Linux = 3, WinCE = 4 */ Name(OSV, Ones) /* Assume nothing */ -Name(PMOD, One) /* Assume APIC */ diff --git a/src/soc/amd/picasso/acpi/globalnvs.asl b/src/soc/amd/picasso/acpi/globalnvs.asl index 3ab35df..8147619 100644 --- a/src/soc/amd/picasso/acpi/globalnvs.asl +++ b/src/soc/amd/picasso/acpi/globalnvs.asl @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
+/* Global variables */ +Name (PMOD, Zero) /* Interrupt Mode used by OS. Assume PIC. */ + /* * NOTE: The layout of the GNVS structure below must match the layout in * soc/amd/picasso/include/soc/nvs.h !!!
-
Aaron Durbin (Code Review) -
Furquan Shaikh (Code Review)
-
Raul Rangel (Code Review)