Yuchen He has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76019?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for TetonGlacierMode dt option ......................................................................
mb/{cfl,cml,whl}: Use true/false macros for TetonGlacierMode dt option
The true/false macros give the reader a better understanding about how the option should be used. Thus, replace 0/1 with false/true.
While on it, remove the quotes from the option name and from the value.
Coffeelake, Cometlake and Whiskeylake mainboards which use that option were changed by the following command ran from the top level directory.
dt_line="chip soc/intel/cannonlake" && \ option="TetonGlacierMode" && \ grep -r "${dt_line}" src/mainboard | \ cut -d ':' -f 1 | \ xargs sed -i'' -e "s/"${option}".*=.*"1"/${option} = true/g" -e "s/"${option}".*=.*"0"/${option} = false/g"
Change-Id: I2bb7d991739881c3377bbbd89e2e17b5aaf18ea8 Signed-off-by: lilacious yuchenhe126@gmail.com --- M src/mainboard/google/puff/variants/ambassador/overridetree.cb M src/mainboard/google/puff/variants/dooly/overridetree.cb M src/mainboard/google/puff/variants/duffy/overridetree.cb M src/mainboard/google/puff/variants/faffy/overridetree.cb M src/mainboard/google/puff/variants/genesis/overridetree.cb M src/mainboard/google/puff/variants/kaisa/overridetree.cb M src/mainboard/google/puff/variants/moonbuggy/overridetree.cb M src/mainboard/google/puff/variants/noibat/overridetree.cb M src/mainboard/google/puff/variants/puff/overridetree.cb M src/mainboard/google/puff/variants/scout/overridetree.cb M src/mainboard/google/puff/variants/wyvern/overridetree.cb 11 files changed, 11 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/76019/1
diff --git a/src/mainboard/google/puff/variants/ambassador/overridetree.cb b/src/mainboard/google/puff/variants/ambassador/overridetree.cb index c3fd102..70b5772 100644 --- a/src/mainboard/google/puff/variants/ambassador/overridetree.cb +++ b/src/mainboard/google/puff/variants/ambassador/overridetree.cb @@ -7,7 +7,7 @@ }"
# Auto-switch between X4 NVMe and X2 NVMe. - register "TetonGlacierMode" = "1" + register TetonGlacierMode = true
register "SerialIoDevMode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoDisabled, diff --git a/src/mainboard/google/puff/variants/dooly/overridetree.cb b/src/mainboard/google/puff/variants/dooly/overridetree.cb index bcc98e4..5bab888 100644 --- a/src/mainboard/google/puff/variants/dooly/overridetree.cb +++ b/src/mainboard/google/puff/variants/dooly/overridetree.cb @@ -14,7 +14,7 @@ }"
# Auto-switch between X4 NVMe and X2 NVMe. - register "TetonGlacierMode" = "1" + register TetonGlacierMode = true
register "SerialIoDevMode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoPci, diff --git a/src/mainboard/google/puff/variants/duffy/overridetree.cb b/src/mainboard/google/puff/variants/duffy/overridetree.cb index 4b0cabc..aff581f 100644 --- a/src/mainboard/google/puff/variants/duffy/overridetree.cb +++ b/src/mainboard/google/puff/variants/duffy/overridetree.cb @@ -7,7 +7,7 @@ }"
# Auto-switch between X4 NVMe and X2 NVMe. - register "TetonGlacierMode" = "1" + register TetonGlacierMode = true
register "SerialIoDevMode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoDisabled, diff --git a/src/mainboard/google/puff/variants/faffy/overridetree.cb b/src/mainboard/google/puff/variants/faffy/overridetree.cb index 8157bb5..54af51e 100644 --- a/src/mainboard/google/puff/variants/faffy/overridetree.cb +++ b/src/mainboard/google/puff/variants/faffy/overridetree.cb @@ -7,7 +7,7 @@ }"
# Auto-switch between X4 NVMe and X2 NVMe. - register "TetonGlacierMode" = "1" + register TetonGlacierMode = true
register "SerialIoDevMode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoDisabled, diff --git a/src/mainboard/google/puff/variants/genesis/overridetree.cb b/src/mainboard/google/puff/variants/genesis/overridetree.cb index 07f7f28..196b683 100644 --- a/src/mainboard/google/puff/variants/genesis/overridetree.cb +++ b/src/mainboard/google/puff/variants/genesis/overridetree.cb @@ -1,6 +1,6 @@ chip soc/intel/cannonlake # Auto-switch between X4 NVMe and X2 NVMe. - register "TetonGlacierMode" = "1" + register TetonGlacierMode = true
register "SerialIoDevMode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoDisabled, diff --git a/src/mainboard/google/puff/variants/kaisa/overridetree.cb b/src/mainboard/google/puff/variants/kaisa/overridetree.cb index c07a1e9..c1272a9 100644 --- a/src/mainboard/google/puff/variants/kaisa/overridetree.cb +++ b/src/mainboard/google/puff/variants/kaisa/overridetree.cb @@ -7,7 +7,7 @@ }"
# Auto-switch between X4 NVMe and X2 NVMe. - register "TetonGlacierMode" = "1" + register TetonGlacierMode = true
register "SerialIoDevMode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoDisabled, diff --git a/src/mainboard/google/puff/variants/moonbuggy/overridetree.cb b/src/mainboard/google/puff/variants/moonbuggy/overridetree.cb index 4649b96..c0c66fa 100644 --- a/src/mainboard/google/puff/variants/moonbuggy/overridetree.cb +++ b/src/mainboard/google/puff/variants/moonbuggy/overridetree.cb @@ -1,6 +1,6 @@ chip soc/intel/cannonlake # Auto-switch between X4 NVMe and X2 NVMe. - register "TetonGlacierMode" = "1" + register TetonGlacierMode = true
register "SerialIoDevMode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoDisabled, diff --git a/src/mainboard/google/puff/variants/noibat/overridetree.cb b/src/mainboard/google/puff/variants/noibat/overridetree.cb index 687d226..ed43258 100644 --- a/src/mainboard/google/puff/variants/noibat/overridetree.cb +++ b/src/mainboard/google/puff/variants/noibat/overridetree.cb @@ -5,7 +5,7 @@ }"
# Auto-switch between X4 NVMe and X2 NVMe. - register "TetonGlacierMode" = "1" + register TetonGlacierMode = true
register "SerialIoDevMode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoDisabled, diff --git a/src/mainboard/google/puff/variants/puff/overridetree.cb b/src/mainboard/google/puff/variants/puff/overridetree.cb index a1b7cd4..d4025e1 100644 --- a/src/mainboard/google/puff/variants/puff/overridetree.cb +++ b/src/mainboard/google/puff/variants/puff/overridetree.cb @@ -1,7 +1,7 @@ chip soc/intel/cannonlake
# Auto-switch between X4 NVMe and X2 NVMe. - register "TetonGlacierMode" = "1" + register TetonGlacierMode = true
register "SerialIoDevMode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoDisabled, diff --git a/src/mainboard/google/puff/variants/scout/overridetree.cb b/src/mainboard/google/puff/variants/scout/overridetree.cb index e027589..8f295f7 100644 --- a/src/mainboard/google/puff/variants/scout/overridetree.cb +++ b/src/mainboard/google/puff/variants/scout/overridetree.cb @@ -1,6 +1,6 @@ chip soc/intel/cannonlake # Auto-switch between X4 NVMe and X2 NVMe. - register "TetonGlacierMode" = "1" + register TetonGlacierMode = true
register "SerialIoDevMode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoDisabled, diff --git a/src/mainboard/google/puff/variants/wyvern/overridetree.cb b/src/mainboard/google/puff/variants/wyvern/overridetree.cb index 2272a06..060bfd0 100644 --- a/src/mainboard/google/puff/variants/wyvern/overridetree.cb +++ b/src/mainboard/google/puff/variants/wyvern/overridetree.cb @@ -1,7 +1,7 @@ chip soc/intel/cannonlake
# Auto-switch between X4 NVMe and X2 NVMe. - register "TetonGlacierMode" = "1" + register TetonGlacierMode = true
register "SataPortsEnable[0]" = "1"